Map arguments optimization #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Atul-source
requested review from
sanfern,
charleskbliu0,
jniesz,
dthaler,
ajayR006,
dalalkaran and
pmoroney
as code owners
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
sanfern
requested changes
Jul 10, 2024
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
sanfern
requested changes
Jul 17, 2024
bpfprogs/bpfmap.go
Outdated
| func (b *BPFMap) Update(value string) error { | ||
|
|
||
| log.Debug().Msgf("update map name %s ID %d", b.Name, b.MapID) | ||
| // The RemoveMissingKeys function is used to delete all entries of eBPF maps, which are used by network functions. |
There was a problem hiding this comment.
Suggested change
| // The RemoveMissingKeys function is used to delete all entries of eBPF maps, which are used by network functions. | |
| // The RemoveMissingKeys function is used to delete all entries of eBPF maps, which are used by ebpf program. |
bpfprogs/bpfmap.go
Outdated
| log.Info().Msgf("updating map %s key %d mapid %d", b.Name, v, b.MapID) | ||
| if err := ebpfMap.Update(unsafe.Pointer(&v), unsafe.Pointer(&x), 0); err != nil { | ||
| return fmt.Errorf("update hash map element failed for key %d error %w", key, err) | ||
| KeyValueMap := make(map[int]bool, 0) |
There was a problem hiding this comment.
Define the size of KeyValueMap to the size of args instead of 0.
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
sanfern
requested changes
Jul 17, 2024
bpfprogs/bpfmap.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // The update function is used to update eBPF maps, which are used by network functions. |
There was a problem hiding this comment.
Suggested change
| // The update function is used to update eBPF maps, which are used by network functions. | |
| // The update function is used to update eBPF maps, which are used by ebpf programs |
Signed-off-by: Atul-source <[email protected]>
sanfern
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have made the changes for map args to take custom key value pairs.