L3AFd Docker build CI integration #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the Docker image and uploading it to Artifactory as part of CI build. Signed-off-by: aka320 <[email protected]>
aka320
requested review from
sanfern,
charleskbliu0,
jniesz,
dthaler,
ajayR006,
dalalkaran and
pmoroney
as code owners
sanfern
requested changes
Jul 3, 2024
.github/workflows/ci-build.yaml
Outdated
| sudo cp ./config/l3afd.cfg ./build-docker | ||
| sudo cp l3afd ./build-docker | ||
| sudo docker build -t l3afd:v2.0.0 -f ./build-docker/Dockerfile ./build-docker | ||
| sudo docker save l3afd:v2.0.0 > l3afd-docker-img-linux-x86_64-v2.0.0.tar |
There was a problem hiding this comment.
Suggested change
| sudo docker save l3afd:v2.0.0 > l3afd-docker-img-linux-x86_64-v2.0.0.tar | |
| sudo docker save l3afd:latest > l3afd-docker-img-linux-x86_64-v2.0.0.tar |
.github/workflows/ci-build.yaml
Outdated
| - uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 | ||
| with: | ||
| name: l3afd-docker-img-linux-x86_64-v2.0.0.tar | ||
| path: l3afd-docker-img-linux-x86_64-v2.0.0.tar |
There was a problem hiding this comment.
Suggested change
| path: l3afd-docker-img-linux-x86_64-v2.0.0.tar | |
| path: l3afd-docker-img-linux-x86_64.tar |
README.md
Outdated
| @@ -47,7 +47,7 @@ cmake --build build | |||
| - L3AFD binary & configuration that is required in the Docker image needs to be built locally and copied to build-docker directory | |||
| - Execute below command to build the docker image | |||
| ``` | |||
| docker build -t l3afd:r2 -f Dockerfile.l3afd . | |||
| docker build -t l3afd:v2.0.0 -f Dockerfile . | |||
There was a problem hiding this comment.
Suggested change
| docker build -t l3afd:v2.0.0 -f Dockerfile . | |
| docker build -t l3afd:<version> -f Dockerfile . |
…nstead of v2.0.0 Signed-off-by: aka320 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the Docker image and uploading it to Artifactory as part of CI build.