Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running L3AFD in a Docker container #395

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Running L3AFD in a Docker container #395

merged 3 commits into from
Jun 5, 2024

Conversation

aka320
Copy link
Contributor

@aka320 aka320 commented May 29, 2024

Changes

  • Added Dockerfile to build the Docker image for L3AFD
  • Update README with the instructions to build L3AFD Docker image and run it in a Container

Testing

  • Able to attach XDP and TC programs using L3AFD Container

github-advanced-security[bot]
github-advanced-security bot found potential problems May 29, 2024
View reviewed changes
aka320 added 2 commits May 29, 2024 17:11
@aka320
Create Dockerfile for L3AFD
a3899df 
Signed-off-by: aka320 <[email protected]>
@aka320
Update README.md
115670b 
- Updating README with the instructions to Build L3AFD Docker image and run it in a Container.

Signed-off-by: aka320 <[email protected]>
pmoroney
pmoroney previously approved these changes May 29, 2024
View reviewed changes
Copy link

@pmoroney pmoroney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it does sound like a good idea to pin the hash for the docker file as suggested by the security bot.

sanfern
sanfern requested changes May 29, 2024
View reviewed changes
README.md Outdated
@@ -60,6 +60,35 @@ go test -tags WINDOWS ./...
# Generate Swagger Docs
See our [Swaggo setup](docs/swagger.md)

# Build L3AFD Docker image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this block in building section

build-docker/Dockerfile Outdated
Comment on lines 19 to 26
vim \
wget \
curl \
linux-tools-generic \
net-tools \
iproute2 \
elfutils \
libjson-c-dev \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix alignment.

@aka320
Addressing review comments
f7ed413 
- Fixing indentation in Dockerfile
- Using specific SHA for Jammy base docker image
- Cosmetic changes for README.md

Signed-off-by: aka320 <[email protected]>
sanfern
sanfern approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@sanfern sanfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aka320 aka320 requested a review from pmoroney June 5, 2024 16:33
charleskbliu0
charleskbliu0 approved these changes Jun 5, 2024
View reviewed changes
Copy link

@charleskbliu0 charleskbliu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@charleskbliu0 charleskbliu0 merged commit 8a48fa0 into l3af-project:main Jun 5, 2024
8 checks passed
@sanfern sanfern added the enhancement New feature or request label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfern sanfern sanfern approved these changes

@charleskbliu0 charleskbliu0 charleskbliu0 approved these changes

@jniesz jniesz Awaiting requested review from jniesz jniesz is a code owner

@dthaler dthaler Awaiting requested review from dthaler

@ajayR006 ajayR006 Awaiting requested review from ajayR006

@dalalkaran dalalkaran Awaiting requested review from dalalkaran dalalkaran is a code owner

@pmoroney pmoroney Awaiting requested review from pmoroney pmoroney is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aka320 @sanfern @pmoroney @charleskbliu0