Adding support for saving the logs in a specified file #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysheth2
force-pushed
the
jay-hv-fixlogging
branch
2 times, most recently
from
7190bb8 to
46f0bcd
Compare
Signed-off-by: Jay Sheth <[email protected]>
Signed-off-by: Jay Sheth <[email protected]>
Signed-off-by: Jay Sheth <[email protected]>
…xing docs Signed-off-by: Jay Sheth <[email protected]>
jaysheth2
force-pushed
the
jay-hv-fixlogging
branch
from
46f0bcd to
6eb8c60
Compare
Signed-off-by: Jay Sheth <[email protected]>
jaysheth2
changed the title
jaysheth2
requested review from
sanfern,
charleskbliu0,
jniesz,
dthaler,
ajayR006,
dalalkaran and
pmoroney
as code owners
sanfern
requested changes
Apr 5, 2024
config/config.go
Outdated
| @@ -105,6 +108,8 @@ func ReadConfig(configPath string) (*Config, error) { | |||
| BPFLogDir: LoadOptionalConfigString(confReader, "l3afd", "bpf-log-dir", ""), | |||
| MinKernelMajorVer: LoadOptionalConfigInt(confReader, "l3afd", "kernel-major-version", 5), | |||
| MinKernelMinorVer: LoadOptionalConfigInt(confReader, "l3afd", "kernel-minor-version", 15), | |||
| FileLogging: LoadOptionalConfigBool(confReader, "l3afd", "file-logging", false), | |||
| FileLogLocation: LoadOptionalConfigString(confReader, "l3afd", "file-log-location", "l3afd.log"), | |||
There was a problem hiding this comment.
Can we have one option that allows the program to write to a specific file path, "log-file-path: /var/log/l3afd.log", if it is provided? Otherwise, if no file path is specified, the program should follow the default behavior of not writing to a log file.
Signed-off-by: Jay Sheth <[email protected]>
sanfern
requested changes
Apr 8, 2024
| @@ -58,6 +59,20 @@ func setupLogging() { | |||
| log.Debug().Msgf("Log level set to %q", logLevel) | |||
| } | |||
|
|
|||
| func saveLogsToFile(conf *config.Config) { | |||
There was a problem hiding this comment.
Can input only FileLogLocation instead of entire conf here.
sanfern
reviewed
Apr 8, 2024
config/l3afd.cfg
Outdated
| @@ -14,7 +14,7 @@ swagger-api-enabled: false | |||
| environment: PROD | |||
| # BpfMapDefaultPath is base path for storing maps | |||
| BpfMapDefaultPath: /sys/fs/bpf | |||
|
|
|||
| file-log-location: l3afd.log | |||
There was a problem hiding this comment.
what is the absolute file location path here?
Signed-off-by: Jay Sheth <[email protected]>
Signed-off-by: Jay Sheth <[email protected]>
sanfern
previously approved these changes
Apr 8, 2024
Signed-off-by: Jay Sheth <[email protected]>
pmoroney
previously approved these changes
Apr 11, 2024
main.go
Outdated
|
|
||
| logFileWithRotation := &lumberjack.Logger{ | ||
| Filename: confFileLogLocation, | ||
| MaxSize: 100, // Max size in megabytes |
There was a problem hiding this comment.
I like log rotation, but are these parameters something that should be configurable by the user?
There was a problem hiding this comment.
Fixed. Added config parameters, that users can utilize to provide log rotation handles
Signed-off-by: Jay Sheth <[email protected]>
sanfern
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, L3AFD logs are only displayed on STDOUT. However, in some usecases, the logging and metrics framework might require the logs to be saved to persistent storage or discs. This PR add the functionality of allowing user to save logs to the file as well. The file includes log-rotation by default