improvement in error handling #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atul-source <[email protected]>
Atul-source
requested review from
sanfern,
charleskbliu0,
jniesz,
dthaler,
ajayR006 and
dalalkaran
as code owners
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
pmoroney
requested changes
Mar 26, 2024
There was a problem hiding this comment.
In the places where we are using the fmt.Errorf() function we should change it to %w since that is still valid according to https://pkg.go.dev/[email protected]#Errorf. If there are test failures we should investigate that and see if we need to modify the tests to handle wrapped errors.
Signed-off-by: Atul-source <[email protected]>
Atul-source
force-pushed
the
logging-improvement
branch
from
6d80064 to
0b0b65d
Compare
sanfern
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have done error handling improvments.