-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding contributor's guide #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions
Signed-off-by: Santhosh Fernandes <[email protected]>
Signed-off-by: Santhosh Fernandes <[email protected]>
Signed-off-by: Santhosh Fernandes <[email protected]>
9a3b3cc
to
b24aacc
Compare
Signed-off-by: Santhosh Fernandes <[email protected]>
Signed-off-by: Santhosh Fernandes <[email protected]>
At bottom of document we should add a blurb "Please refer to the governance repo for Project Charter, Code of Conduct, Release Process, and Committee Members." |
Signed-off-by: Santhosh Fernandes <[email protected]>
Signed-off-by: Santhosh Fernandes <[email protected]>
Signed-off-by: Santhosh Fernandes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created new security sub-group that is private. I would recommend this one change and I will approve
d36b5a4
to
3820b5f
Compare
Signed-off-by: Santhosh Fernandes <[email protected]>
3820b5f
to
d745b93
Compare
* Ensure the PR description clearly describes the problem and solution. Include the relevant issue number | ||
if applicable. | ||
|
||
### Guidelines for pull requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is present in the TOC.
Signed-off-by: Santhosh Fernandes <[email protected]>
345d69d
to
14bdfd6
Compare
* Ensure the PR description clearly describes the problem and solution. Include the relevant issue number | ||
if applicable. | ||
|
||
### Guidelines for pull requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is present in the TOC.
This document is to define steps to contribute. This address the issue #9.