Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding contributor's guide #16

Merged
merged 11 commits into from
Apr 12, 2022
Merged

Conversation

sanfern
Copy link
Contributor

@sanfern sanfern commented Feb 8, 2022

This document is to define steps to contribute. This address the issue #9.

@sanfern sanfern linked an issue Feb 8, 2022 that may be closed by this pull request
Copy link
Contributor

@satyaranjanp satyaranjanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanfern sanfern requested a review from jniesz February 14, 2022 10:28
Copy link

@dalalkaran dalalkaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jniesz jniesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions

Signed-off-by: Santhosh Fernandes <[email protected]>
Signed-off-by: Santhosh Fernandes <[email protected]>
@sanfern sanfern force-pushed the sanfern-contrib-doc branch from 9a3b3cc to b24aacc Compare February 15, 2022 06:35
Signed-off-by: Santhosh Fernandes <[email protected]>
@jniesz
Copy link
Contributor

jniesz commented Mar 31, 2022

At bottom of document we should add a blurb

"Please refer to the governance repo for Project Charter, Code of Conduct, Release Process, and Committee Members."

Signed-off-by: Santhosh Fernandes <[email protected]>
sanfern added 2 commits April 6, 2022 17:12
Signed-off-by: Santhosh Fernandes <[email protected]>
Signed-off-by: Santhosh Fernandes <[email protected]>
Copy link
Contributor

@jniesz jniesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created new security sub-group that is private. I would recommend this one change and I will approve

@sanfern sanfern force-pushed the sanfern-contrib-doc branch from d36b5a4 to 3820b5f Compare April 8, 2022 10:03
Signed-off-by: Santhosh Fernandes <[email protected]>
@sanfern sanfern force-pushed the sanfern-contrib-doc branch from 3820b5f to d745b93 Compare April 11, 2022 10:53
* Ensure the PR description clearly describes the problem and solution. Include the relevant issue number
if applicable.

### Guidelines for pull requests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is present in the TOC.

Signed-off-by: Santhosh Fernandes <[email protected]>
@sanfern sanfern force-pushed the sanfern-contrib-doc branch from 345d69d to 14bdfd6 Compare April 12, 2022 02:38
* Ensure the PR description clearly describes the problem and solution. Include the relevant issue number
if applicable.

### Guidelines for pull requests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is present in the TOC.

@sanfern sanfern merged commit 091cc99 into l3af-project:main Apr 12, 2022
@sanfern sanfern deleted the sanfern-contrib-doc branch April 12, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CONTRIBUTING.md file
5 participants