chore: naming, gosimports

Signed-off-by: Keith Zantow <[email protected]>

.github/workflows/build.yml

@@ -3,7 +3,7 @@
 name: build
 on: [push, pull_request]
 jobs:
-  tests:
+  tests: # this is the only required check
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -17,7 +17,7 @@ jobs:
         with:
           path-to-profile: profile.cov
 
-  tests-latest:
+  test-platforms:
     strategy:
       matrix:
         go-version: ['stable']

builder/build_package.go

@@ -18,18 +18,18 @@ import (
 func BuildPackageSection(packageName string, dirRoot string, pathsIgnore []string) (*spdx.Package, error) {
 	// build the file section first, so we'll have it available
 	// for calculating the package verification code
-	relativePaths, err := utils.GetAllFilePaths(dirRoot, pathsIgnore)
+	shortPaths, err := utils.GetAllFilePaths(dirRoot, pathsIgnore)
 
 	if err != nil {
 		return nil, err
 	}
 
 	files := []*spdx.File{}
 	fileNumber := 0
-	for _, filePath := range relativePaths {
-		// SPDX spec says file names should generally start with ./
+	for _, shortPath := range shortPaths {
+		// SPDX spec says file names should generally start with ./ and the shortPath already starts with /
 		// see: https://spdx.github.io/spdx-spec/v2.3/file-information/#81-file-name-field
-		relativePath := "." + filePath
+		relativePath := "." + shortPath
 		newFile, err := BuildFileSection(relativePath, dirRoot, fileNumber)
 		if err != nil {
 			return nil, err

spdx/v2/v2_1/document.go

@@ -4,7 +4,7 @@
 package v2_1
 
 import (
-	"github.com/anchore/go-struct-converter"
+	converter "github.com/anchore/go-struct-converter"
 
 	"github.com/spdx/tools-golang/spdx/v2/common"
 )

spdx/v2/v2_2/json/empty_values_test.go

@@ -2,10 +2,12 @@ package json
 
 import (
 	"encoding/json"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
 	"github.com/spdx/tools-golang/spdx/v2/common"
 	spdx "github.com/spdx/tools-golang/spdx/v2/v2_2"
-	"github.com/stretchr/testify/require"
-	"testing"
 )
 
 func Test_omitsAppropriateProperties(t *testing.T) {