upgrade runtime controller to 0.15 #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/L
kyma-bot
added
size/XL
ruanxin
commented
Jul 14, 2023
|
@ruanxin Can you rebase main and delete the temporary unregistering of metrics with this PR as well please? |
unify kymaExists check in tests
ruanxin
added
do-not-merge/hold
|
/test pull-lifecycle-mgr-tests |
# Conflicts: # tests/e2e_test/watcher_test.go
|
/test pull-lifecycle-mgr-tests |
1 similar comment
|
/test pull-lifecycle-mgr-tests |
enhance deleteCR logic
# Conflicts: # controllers/withwatcher/kyma_controller_test.go
|
/test pull-lifecycle-mgr-tests |
lindnerby
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8serrors.IsNotFoundwith this customized function, based on the workaround solution mentioned in this open issue Usage of client-go'sdiscovery.ErrGroupDiscoveryFailedbreaks apimachineryerrors.IsNotFoundkubernetes-sigs/controller-runtime#2354 thanks @LeelaChacha bring this to attention.