Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use fixed envtest version for integration tests #2303

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Mar 6, 2025

Description

Changes proposed in this pull request:

  • integration tests stopped working, see e.g., https://github.com/kyma-project/lifecycle-manager/actions/runs/13699632137/job/38315898587?pr=2295
  • reason seems to be that we run integration tests using envtest@latest
    • the latest version has been updated to go 1.24 while we are still on 1.24
    • to fix that, proposing to use the previous version of envtest
    • I anyway think it is reasonable to rely on fixed versions
  • the proposed ticket below is still valid, and of course we also need to migrate to go 1.24. So far we didn't because of the linting issue.

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner March 6, 2025 15:46
Copy link

github-actions bot commented Mar 6, 2025

⚠️ Pipeline-related file changes detected! Please review if related updates (e.g. manifest generation or workflow adjustments) are required.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 6, 2025
@c-pius c-pius enabled auto-merge (squash) March 6, 2025 16:01
@c-pius c-pius merged commit 088fd2f into kyma-project:main Mar 6, 2025
195 of 201 checks passed
@c-pius c-pius deleted the fix/integration-tests branch March 6, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! pipeline-changed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants