Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: RBAC cleanup #2207

Merged
merged 31 commits into from
Feb 27, 2025
Merged

chore: RBAC cleanup #2207

merged 31 commits into from
Feb 27, 2025

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented Jan 24, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Remove kubebuilder markers for RBAC creation from various controllers, since it will always create ClusterRole
  • Restructure & cleanup RBAC resources
  • Change manager ClusterRole to kcp-system namespaced Role
  • Remove duplicate Roles
  • Additional cleanup

Related issue(s)

@lindnerby lindnerby added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@lindnerby lindnerby requested a review from a team as a code owner January 24, 2025 08:22
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2025
@lindnerby lindnerby changed the title test: remove kb marker chore: RBAC cleanup Feb 13, 2025
@lindnerby lindnerby removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2025
@lindnerby lindnerby linked an issue Feb 13, 2025 that may be closed by this pull request
Remove excess permissions in kcp-system namespace #2082
Closed
4 tasks
c-pius
c-pius reviewed Feb 26, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 27, 2025
@c-pius c-pius merged commit 2b4b9a8 into kyma-project:main Feb 27, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-pius c-pius c-pius approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove excess permissions in kcp-system namespace
3 participants
@lindnerby @c-pius @kyma-bot