Updated tests to check default operation strategies creation

kuujis · Mar 12, 2024 · c6c1932 · c6c1932
1 parent 07f6f76
commit c6c1932
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 59 deletions.
diff --git a/plugin/sampling/strategystore/static/fixtures/5504_strategies.json b/plugin/sampling/strategystore/static/fixtures/5504_strategies.json
diff --git a/plugin/sampling/strategystore/static/strategy_store_test.go b/plugin/sampling/strategystore/static/strategy_store_test.go
@@ -470,15 +470,24 @@ func TestServiceNoPerOperationStrategies(t *testing.T) {
 
 	s, err := store.GetSamplingStrategy(context.Background(), "ServiceA")
 	require.NoError(t, err)
-	assert.Equal(t, 1.0, s.OperationSampling.DefaultSamplingProbability)
-	assert.Len(t, s.OperationSampling.PerOperationStrategies, 1)
+	require.NotNil(t, s.OperationSampling)
+	os := s.OperationSampling
+	assert.EqualValues(t, 1, os.DefaultSamplingProbability)
+	require.Len(t, os.PerOperationStrategies, 1)
+	assert.Equal(t, "/health", os.PerOperationStrategies[0].Operation)
+	assert.EqualValues(t, 0.0, os.PerOperationStrategies[0].ProbabilisticSampling.SamplingRate)
+	expected := makeResponse(api_v2.SamplingStrategyType_PROBABILISTIC, 1.0)
+	assert.Equal(t, *expected.ProbabilisticSampling, *s.ProbabilisticSampling)
 
 	s, err = store.GetSamplingStrategy(context.Background(), "ServiceB")
 	require.NoError(t, err)
-	assert.Equal(t, 0.2, s.OperationSampling.DefaultSamplingProbability)
-	assert.Len(t, s.OperationSampling.PerOperationStrategies, 1)
-
-	expected := makeResponse(api_v2.SamplingStrategyType_RATE_LIMITING, 3)
+	require.NotNil(t, s.OperationSampling)
+	os = s.OperationSampling
+	assert.EqualValues(t, 0.2, os.DefaultSamplingProbability)
+	require.Len(t, os.PerOperationStrategies, 1)
+	assert.Equal(t, "/health", os.PerOperationStrategies[0].Operation)
+	assert.EqualValues(t, 0.0, os.PerOperationStrategies[0].ProbabilisticSampling.SamplingRate)
+	expected = makeResponse(api_v2.SamplingStrategyType_RATE_LIMITING, 3)
 	assert.Equal(t, *expected.RateLimitingSampling, *s.RateLimitingSampling)
 }