fix: new emui correct handling of Bool input type #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dartoxian actually the default (in the absence of type set in the data coming from the API) should be |
Dartoxian
changed the title
adschwartz
approved these changes
Nov 8, 2023
Dartoxian
force-pushed
the
fix/em-default-arg-type-bool
branch
from
3a78d46 to
15a0cb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR corrects the enclave configuration form input to use boolean if a package argument type is boolean - which is enum value 0 and was previously treated as falsy.
Screenshot of fix
Is this change user facing?
YES