Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noop inheritance from pointcloudtransform #58

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Noop inheritance from pointcloudtransform #58

merged 2 commits into from
Aug 13, 2020

Conversation

kumuji
Copy link
Owner

@kumuji kumuji commented Aug 13, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes that NoOp operation fails, and throws NotImplementedError

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@kumuji kumuji added the bug Something isn't working label Aug 13, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #58 into master will increase coverage by 0.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   73.01%   73.67%   +0.66%     
==========================================
  Files           8        8              
  Lines         604      604              
  Branches       86       86              
==========================================
+ Hits          441      445       +4     
+ Misses        139      135       -4     
  Partials       24       24              
Impacted Files Coverage Δ
src/volumentations/core/transforms_interface.py 70.46% <100.00%> (+2.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd85427...e584400. Read the comment docs.

@kumuji kumuji merged commit 995eca6 into master Aug 13, 2020
@kumuji kumuji deleted the noop_fix branch August 13, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants