Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): don't remove Service if MeshGateway is absent for a while (i.e. due to renaming) #8450

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

lobkovilya
Copy link
Contributor

Checklist prior to review

@lobkovilya lobkovilya requested a review from a team as a code owner November 23, 2023 17:19
@lobkovilya lobkovilya requested review from slonka and lukidzi and removed request for a team November 23, 2023 17:19
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change updateStatus to set the mesh_k8s.GatewayInstanceNoGatewayMatched Condition even if we have a svc object.

@lobkovilya
Copy link
Contributor Author

Good point, I updated the PR

lobkovilya added a commit to lobkovilya/kuma that referenced this pull request Nov 27, 2023
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Nov 28, 2023
@lobkovilya lobkovilya merged commit c3c5eaa into kumahq:master Nov 28, 2023
@lobkovilya lobkovilya deleted the fix/handle-meshgateway-rename branch November 28, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GatewayInstanceReconciler to not remove Service if MeshGateway is removed
2 participants