Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations #8301

Merged
merged 4 commits into from
Nov 9, 2023
Merged

fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations #8301

merged 4 commits into from
Nov 9, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Nov 9, 2023

instead of #8300

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@slonka slonka requested a review from a team as a code owner November 9, 2023 09:26
@slonka slonka requested review from jakubdyszkiewicz and bartsmykla and removed request for a team November 9, 2023 09:26
@slonka slonka mentioned this pull request Nov 9, 2023
Closed
5 tasks
@slonka slonka merged commit e643e50 into kumahq:release-2.5 Nov 9, 2023
@slonka slonka added the backport label Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023 •
edited
Loading

backporting to release-2.3 with action

backporting to release-2.2 with action
backporting to release-2.1 with action

@kumahq kumahq bot mentioned this pull request Nov 9, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Nov 9, 2023
@slonka @michaelbeaumont @kumahq
fix(k8s): don't temporarily remove all AvailableServices on ZoneIngre…
01a8c58 
…ss Pod reconciliations (#8301)

* test(k8s): add existing ZoneIngress test

Signed-off-by: Mike Beaumont <[email protected]>

* fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations

Signed-off-by: Mike Beaumont <[email protected]>

* test: add ResourceConverter

Signed-off-by: Mike Beaumont <[email protected]>

* test: update with fixed golden file

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
@kumahq kumahq bot mentioned this pull request Nov 9, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Nov 9, 2023
@slonka @michaelbeaumont @kumahq
fix(k8s): don't temporarily remove all AvailableServices on ZoneIngre…
b51ff52 
…ss Pod reconciliations (#8301)

* test(k8s): add existing ZoneIngress test

Signed-off-by: Mike Beaumont <[email protected]>

* fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations

Signed-off-by: Mike Beaumont <[email protected]>

* test: add ResourceConverter

Signed-off-by: Mike Beaumont <[email protected]>

* test: update with fixed golden file

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
@kumahq kumahq bot mentioned this pull request Nov 9, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Nov 9, 2023
@slonka @michaelbeaumont @kumahq
fix(k8s): don't temporarily remove all AvailableServices on ZoneIngre…
b86a58c 
…ss Pod reconciliations (#8301)

* test(k8s): add existing ZoneIngress test

Signed-off-by: Mike Beaumont <[email protected]>

* fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations

Signed-off-by: Mike Beaumont <[email protected]>

* test: add ResourceConverter

Signed-off-by: Mike Beaumont <[email protected]>

* test: update with fixed golden file

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
@kumahq kumahq bot mentioned this pull request Nov 9, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Nov 9, 2023
@slonka @michaelbeaumont @kumahq
fix(k8s): don't temporarily remove all AvailableServices on ZoneIngre…
eb6ea65 
…ss Pod reconciliations (#8301)

* test(k8s): add existing ZoneIngress test

Signed-off-by: Mike Beaumont <[email protected]>

* fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations

Signed-off-by: Mike Beaumont <[email protected]>

* test: add ResourceConverter

Signed-off-by: Mike Beaumont <[email protected]>

* test: update with fixed golden file

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
slonka added a commit that referenced this pull request Nov 10, 2023
@kumahq @slonka @michaelbeaumont
fix(k8s): don't temporarily remove all AvailableServices on ZoneIngre…
75eab0c 
…ss Pod reconciliations (backport of #8301) (#8306)

fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations (#8301)

* test(k8s): add existing ZoneIngress test



* fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations



* test: add ResourceConverter



* test: update with fixed golden file



---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
slonka added a commit that referenced this pull request Nov 10, 2023
@kumahq @slonka @michaelbeaumont
fix(k8s): don't temporarily remove all AvailableServices on ZoneIngre…
136255b 
…ss Pod reconciliations (backport of #8301) (#8307)

fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations (#8301)

* test(k8s): add existing ZoneIngress test



* fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations



* test: add ResourceConverter



* test: update with fixed golden file



---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
slonka added a commit that referenced this pull request Nov 10, 2023
@kumahq @slonka @michaelbeaumont
fix(k8s): don't temporarily remove all AvailableServices on ZoneIngre…
5496ca3 
…ss Pod reconciliations (backport of #8301) (#8305)

fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations (#8301)

* test(k8s): add existing ZoneIngress test



* fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations



* test: add ResourceConverter



* test: update with fixed golden file



---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
slonka added a commit that referenced this pull request Nov 10, 2023
@kumahq @slonka @michaelbeaumont
fix(k8s): don't temporarily remove all AvailableServices on ZoneIngre…
62045c1 
…ss Pod reconciliations (backport of #8301) (#8308)

fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations (#8301)

* test(k8s): add existing ZoneIngress test



* fix(k8s): don't temporarily remove all AvailableServices on ZoneIngress Pod reconciliations



* test: add ResourceConverter



* test: update with fixed golden file



---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
@jakubdyszkiewicz jakubdyszkiewicz mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slonka @jakubdyszkiewicz @michaelbeaumont