Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): change affinityTag field in MeshLoadBalancingStrategy t… #8292

Closed
wants to merge 1 commit into from

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Nov 8, 2023

…o optional

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@Automaat Automaat requested a review from a team as a code owner November 8, 2023 11:14
@Automaat Automaat requested review from bartsmykla and lukidzi and removed request for a team November 8, 2023 11:14
@Automaat
Copy link
Contributor Author

Automaat commented Nov 8, 2023

/golden_files

@Automaat
Copy link
Contributor Author

Automaat commented Nov 8, 2023

builds are failing because of branch naming, reopening from new branch #8294

@Automaat Automaat closed this Nov 8, 2023
@bartsmykla bartsmykla deleted the release-2.5-fix-affinity-tags branch November 14, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants