Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-dp): fix build #8282

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix(kuma-dp): fix build #8282

merged 1 commit into from
Nov 7, 2023

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Nov 7, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Marcin Skalski <[email protected]>
@Automaat Automaat requested a review from a team as a code owner November 7, 2023 12:50
@Automaat Automaat requested review from slonka and lukidzi and removed request for a team November 7, 2023 12:50
@Automaat Automaat enabled auto-merge (squash) November 7, 2023 12:57
@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Nov 7, 2023
@Automaat Automaat merged commit a9a165b into release-2.5 Nov 7, 2023
@Automaat Automaat deleted the fix/release-2.5-build branch November 7, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants