Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): better lifecycle when context is getting cancelled #8268

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix(core): better lifecycle when context is getting cancelled #8268

merged 2 commits into from
Nov 7, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Nov 6, 2023

  • For kuma-dp we properly shutdown when context is closed
  • In KDS the client cancelled being closed make all the components stop

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana requested a review from a team as a code owner November 6, 2023 14:36
@lahabana lahabana requested review from slonka and bartsmykla and removed request for a team November 6, 2023 14:36
@lahabana lahabana added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Nov 6, 2023
@lahabana lahabana force-pushed the fixShutdown branch 2 times, most recently from 4111618 to eb983dd Compare November 6, 2023 14:42
@lahabana
fix(core): better lifecycle when context is getting cancelled
05bd2e4 
- For kuma-dp we properly shutdown when context is closed
- In KDS the client cancelled being closed make all the components stop

Signed-off-by: Charly Molter <[email protected]>
slonka
slonka approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general looks good, but there is something wrong with the unit tests https://app.circleci.com/pipelines/github/kumahq/kuma?branch=pull%2F8268

app/kuma-dp/pkg/dataplane/command/base_command.go Show resolved Hide resolved
pkg/kds/mux/client.go Outdated Show resolved Hide resolved
@lahabana
fix test
cf25ff4 
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana merged commit 2437c1c into kumahq:release-2.5 Nov 7, 2023
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
@lahabana lahabana deleted the fixShutdown branch March 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @slonka