-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp): using policy name with "." causes hash to be inserted in the wrong place on the zone #8240
Merged
lobkovilya
merged 7 commits into
kumahq:release-2.5
from
lobkovilya:fix/hash-suffix-regardless-ns
Nov 8, 2023
Merged
fix(kuma-cp): using policy name with "." causes hash to be inserted in the wrong place on the zone #8240
lobkovilya
merged 7 commits into
kumahq:release-2.5
from
lobkovilya:fix/hash-suffix-regardless-ns
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
lobkovilya
commented
Nov 2, 2023
Ok I'm completely confused with names. Can we have a doc that describes what happens to names between global and zones in all cases (global k8s, global universal, zone k8s, zone universal) ? |
Sure, do you think it should be a kuma-website doc or a more developer-oriented doc in this repo? |
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
@lahabana I pushed the doc under the |
lahabana
reviewed
Nov 3, 2023
lahabana
reviewed
Nov 3, 2023
lahabana
reviewed
Nov 3, 2023
lahabana
reviewed
Nov 3, 2023
lahabana
reviewed
Nov 3, 2023
lahabana
reviewed
Nov 3, 2023
lahabana
reviewed
Nov 3, 2023
lukidzi
reviewed
Nov 7, 2023
lukidzi
reviewed
Nov 7, 2023
Signed-off-by: Ilya Lobkov <[email protected]>
lukidzi
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we allow a dot in the policy name, we can't use functions like
CoreNameToK8sName
that try to parse the name and make assumptions based on.<namespace>
suffix.Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --