Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): add locality aware implementation for egress #8233

Merged
merged 30 commits into from
Nov 7, 2023
Merged

feat(kuma-cp): add locality aware implementation for egress #8233

merged 30 commits into from
Nov 7, 2023

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Nov 2, 2023

Fixes: #8073

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@Automaat Automaat requested a review from a team as a code owner November 2, 2023 10:18
@Automaat Automaat requested review from slonka and bartsmykla and removed request for a team November 2, 2023 10:18
slonka
slonka approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving but I'm not the most knowledge person about egress routing

pkg/plugins/policies/core/matchers/egress.go Show resolved Hide resolved
test/e2e_env/multizone/localityawarelb/locality_aware_multizone_hybrid_egress.go Show resolved Hide resolved
app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml Show resolved Hide resolved
bartsmykla
bartsmykla approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any other suggestions/questions than already existing, so LGTM.

@bartsmykla
Copy link
Contributor

/format

@slonka slonka added ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) and removed ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) labels Nov 3, 2023
@Automaat
feat(kuma-cp): review
c3a114c 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat Automaat added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Nov 3, 2023
slonka and others added 3 commits November 3, 2023 12:58
@slonka slonka changed the base branch from master to release-2.5 November 3, 2023 15:29
@Automaat
feat(kuma-cp): review
b51539b 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
cb34eeb 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
d8813b9 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
dbdfc8f 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
b50c090 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
77a722c 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
ba4392c 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
Automaat and others added 11 commits November 6, 2023 12:03
@Automaat
feat(kuma-cp): review
72f3915 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
a572691 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
69ba403 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
a493fa3 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
39bcc8e 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
5fcd5ce 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
73d2511 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
fbd048d 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
Merge branch 'release-2.5' into feat/lb-egress
ccb2596 
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
c72c08f 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
c73a352 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(kuma-cp): review
fa354d1 
Fixes: #8237
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat Automaat merged commit c1ace1a into release-2.5 Nov 7, 2023
@Automaat Automaat deleted the feat/lb-egress branch November 7, 2023 09:45
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya left review comments

@slonka slonka slonka approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

@lukidzi lukidzi lukidzi approved these changes

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Basic functionality of Locality Aware Load Balancing
5 participants
@Automaat @bartsmykla @slonka @lobkovilya @lukidzi