Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rsa): add support for PKIX encoded pubkeys #8179

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

nicoche
Copy link
Contributor

@nicoche nicoche commented Oct 30, 2023

Checklist prior to review

  • [Link to relevant issue]
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? -- No
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) -- No

@nicoche nicoche force-pushed the rsa-support-pkix-encoded-keys branch from 9bd0071 to 8152099 Compare October 30, 2023 14:09
@nicoche nicoche changed the title Add support for PKIX public keys feat(rsa): add support for PKIX encoded pubkeys Oct 30, 2023
@nicoche nicoche force-pushed the rsa-support-pkix-encoded-keys branch from 8152099 to 2bf48bc Compare October 30, 2023 14:20
@nicoche nicoche marked this pull request as ready for review October 30, 2023 14:20
@nicoche nicoche requested a review from a team as a code owner October 30, 2023 14:20
@nicoche nicoche requested review from michaelbeaumont and lukidzi and removed request for a team October 30, 2023 14:20
@bartsmykla bartsmykla merged commit 8527dde into kumahq:master Oct 31, 2023
@nicoche nicoche deleted the rsa-support-pkix-encoded-keys branch October 31, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants