Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-server): new inspect api #8148

Merged
merged 4 commits into from
Oct 30, 2023
Merged

feat(api-server): new inspect api #8148

merged 4 commits into from
Oct 30, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Oct 25, 2023 •
edited
Loading

No kumactl for the moment will add in a follow up PR.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Oct 26, 2023
@lahabana lahabana force-pushed the fixInspect branch 2 times, most recently from 3f85f4a to bf9c0b9 Compare October 26, 2023 12:42
@lahabana lahabana marked this pull request as ready for review October 26, 2023 12:43
@lahabana lahabana requested a review from a team as a code owner October 26, 2023 12:43
@lahabana lahabana requested review from michaelbeaumont and lukidzi and removed request for a team October 26, 2023 12:43
michaelbeaumont
michaelbeaumont reviewed Oct 27, 2023
View reviewed changes
mk/docs.mk Show resolved Hide resolved
docs/generated/openapi.yaml Outdated Show resolved Hide resolved
pkg/api-server/resource_endpoints_test.go Show resolved Hide resolved
@lahabana lahabana enabled auto-merge (squash) October 30, 2023 08:32
@lahabana lahabana mentioned this pull request Oct 30, 2023
Merged
5 tasks
@lahabana
fix test
6811f9b 
Signed-off-by: Charly Molter <[email protected]>
@lahabana
Merge branch 'master' into fixInspect
83d6f2a 
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana merged commit 40eddf0 into kumahq:master Oct 30, 2023
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
@lahabana lahabana deleted the fixInspect branch March 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lahabana @michaelbeaumont @lukidzi