Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): fix Zone{In|E}gress sync when no mesh #8128

Conversation

bartsmykla
Copy link
Contributor

  • Add ZoneEgresses to AggregatetMeshContexts when there is no mesh.
  • Sync ZoneIngresses and ZoneEgresses only when the hash changes.
  • Return an error with the correct resource type (ZoneEgress) when a ZoneEgress cannot be found.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • No relevant issue
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
    • Manually tested on k3d
  • Do you need to update UPGRADE.md?
    • There is no need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • It does

- Add ZoneEgresses to AggregatetMeshContexts when there is no mesh.
- Sync ZoneIngresses and ZoneEgresses only when the hash changes.
- Return an error with the correct resource type (ZoneEgress) when
  a ZoneEgress cannot be found.

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla requested a review from a team as a code owner October 25, 2023 03:32
@bartsmykla bartsmykla added the ci/force-publish PR: push artifacts even if we're on a PR (use very carefully) label Oct 25, 2023
@bartsmykla bartsmykla closed this Oct 25, 2023
@bartsmykla bartsmykla reopened this Oct 25, 2023
@bartsmykla
Copy link
Contributor Author

Closing in favour of #8129 as I need to publish it and it's not possible for forks (secrets are not shared with PRs from forks)

@bartsmykla bartsmykla closed this Oct 25, 2023
@bartsmykla bartsmykla deleted the fix/zoneegress-and-zone-ingress-when-no-mesh-fix branch October 25, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci/force-publish PR: push artifacts even if we're on a PR (use very carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant