Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MeshLoadBalancingStrategy): new locality aware api #8082

Merged
merged 10 commits into from
Oct 26, 2023
Merged

feat(MeshLoadBalancingStrategy): new locality aware api #8082

merged 10 commits into from
Oct 26, 2023

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Oct 20, 2023 •
edited by jakubdyszkiewicz
Loading

Checklist prior to review

Fix #8072

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@Automaat Automaat requested a review from a team as a code owner October 20, 2023 09:27
@Automaat Automaat requested review from slonka and bartsmykla and removed request for a team October 20, 2023 09:27
@slonka
Copy link
Contributor

slonka commented Oct 23, 2023

Can you link the issue for this?

@Automaat
feat(policy): change validation
9df16de 
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(policy): code review
9c66ff1 
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(policy): code review
729a773 
Signed-off-by: Marcin Skalski <[email protected]>
@slonka
Copy link
Contributor

slonka commented Oct 25, 2023

Madr: https://github.com/kumahq/kuma/pull/8022/files

slonka
slonka requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of smaller and a bit bigger changes. Please add tests for the cases I mentioned if they make sense.

app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml Outdated Show resolved Hide resolved
app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml Show resolved Hide resolved
app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml Outdated Show resolved Hide resolved
pkg/plugins/policies/meshloadbalancingstrategy/api/v1alpha1/validator.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshloadbalancingstrategy/api/v1alpha1/validator.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshloadbalancingstrategy/api/v1alpha1/validator.go Show resolved Hide resolved
pkg/plugins/policies/meshloadbalancingstrategy/api/v1alpha1/validator.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshloadbalancingstrategy/api/v1alpha1/validator.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshloadbalancingstrategy/api/v1alpha1/validator.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshloadbalancingstrategy/api/v1alpha1/validator.go Show resolved Hide resolved
@Automaat
feat(policy): code review
62adb98 
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(policy): code review
a64f8a0 
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(policy): fix test
14043e7 
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(policy): fix test
d0fecd5 
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
feat(policy): code review
850f227 
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat Automaat merged commit afef153 into kumahq:master Oct 26, 2023
@Automaat Automaat deleted the feat/localityAware-api branch October 26, 2023 12:30
@lahabana lahabana changed the title feat(policy): extend meshloadbalancingstrategy with new locality aware api feat(MeshLoadBalancingStrategy): new locality aware api Nov 3, 2023
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi left review comments

@slonka slonka slonka approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement API for Locality Aware Load Balancing
3 participants
@Automaat @slonka @lukidzi