Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(DEVELOPER.md): remove clang exception #8079

Merged
merged 1 commit into from
Oct 20, 2023
Merged

docs(DEVELOPER.md): remove clang exception #8079

merged 1 commit into from
Oct 20, 2023

Conversation

lahabana
Copy link
Contributor

This was fixed a while back

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

This was fixed a while back

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested a review from a team as a code owner October 20, 2023 08:29
@lahabana lahabana requested review from michaelbeaumont and slonka and removed request for a team October 20, 2023 08:29
@slonka slonka merged commit f3a3e97 into master Oct 20, 2023
@slonka slonka deleted the lahabana-patch-1 branch October 20, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants