Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): allow to set log level for {in|e}gress #8077

Conversation

bartsmykla
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • no relevant issue
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • it won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
    • manually tested
  • Do you need to update UPGRADE.md?
    • there is no need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • there is no need

Changelog: skip

@bartsmykla bartsmykla added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Oct 20, 2023
@bartsmykla bartsmykla requested a review from johncowen October 20, 2023 04:28
@bartsmykla bartsmykla requested a review from a team as a code owner October 20, 2023 04:28
@bartsmykla bartsmykla requested review from michaelbeaumont, slonka, johnharris85 and a team and removed request for a team and johncowen October 20, 2023 04:28
@bartsmykla bartsmykla enabled auto-merge (squash) October 20, 2023 04:30
@bartsmykla bartsmykla merged commit f676dad into kumahq:master Oct 20, 2023
@bartsmykla bartsmykla deleted the chore/allow-to-set-log-level-for-egress-and-igress-in-helm branch October 20, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants