Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-server): 400 error on admin operations on not yet connected stream #8039

Merged

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Oct 12, 2023

return 400 error on requests trying to execute admin operations on not yet connected stream

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

…ions on not yet connected stream

Signed-off-by: slonka <[email protected]>
@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Oct 12, 2023
@lahabana
Copy link
Contributor

Also maybe #7937 will influence what you do here

@slonka slonka marked this pull request as ready for review October 13, 2023 11:09
@slonka slonka requested a review from a team as a code owner October 13, 2023 11:09
@slonka slonka requested review from jakubdyszkiewicz and lobkovilya and removed request for a team October 13, 2023 11:10
@slonka slonka merged commit 3c23a6e into kumahq:master Oct 13, 2023
@lahabana lahabana changed the title fix(api): 400 error on admin operations on not yet connected stream fix(api-server): 400 error on admin operations on not yet connected stream Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants