perf(store): postgres transactions #7995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
Introducing postgres transactions.
This PR does NOT introduce need for transactions in Kuma, this is just a perf optimization for stores that support transactions.
Enrich ResourceStore vs new interface
I introduced a new interface called Transactions, so the transaction can be used by either ResourceStore and ResourceManager. If I would add a new method in ResourceStore we would also add this to ResourceManager.
Transaction in Context vs store opts
I decided to propagate transaction implicitly in context instead of explicitly in store opts like
CreateInTx(tx)
. This is more flexible with less changes to the code. We could also for example open a transaction when we create new Mesh without addingCreateInTx
to every call.syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?