Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): meta validation compatible with Kubernetes naming rules #7976

Merged
merged 9 commits into from
Oct 17, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Oct 6, 2023

Checklist prior to review

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing upgrade.md note btw

Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
@lobkovilya lobkovilya marked this pull request as ready for review October 10, 2023 12:24
@lobkovilya lobkovilya requested a review from a team as a code owner October 10, 2023 12:24
@lobkovilya lobkovilya requested review from jakubdyszkiewicz and Automaat and removed request for a team October 10, 2023 12:24
@lobkovilya lobkovilya force-pushed the fix/update-validate-meta-regex branch from 84a240f to 1eaf56c Compare October 12, 2023 14:59
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
@lobkovilya lobkovilya merged commit 6e9d4d2 into kumahq:master Oct 17, 2023
@lobkovilya lobkovilya deleted the fix/update-validate-meta-regex branch October 17, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidateMeta function doesn't follow Kubernetes naming convention
4 participants