-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(policy): improve targetRef name and tags validation #7972
fix(policy): improve targetRef name and tags validation #7972
Conversation
Added validation for targetRef name and tags as required. Also, MeshGateway and MeshHTTPRoute kind validations are included. Signed-off-by: alparslanavci <[email protected]>
501dc6c
to
bf1bf5b
Compare
@bartsmykla @Automaat can you take a look at this? also @lobkovilya might be interested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits but lgtm overall
Signed-off-by: alparslanavci <[email protected]>
Thanks for the review, @bartsmykla! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're reintroducing things that already exists.
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
@alparslanavci I allowed myself to address @lahabana remarks. Please have a look if everything is ok for you and I would merge it then. |
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: alparslanavci <[email protected]>
This reverts commit 75e2a38. Signed-off-by: alparslanavci <[email protected]>
08bf223
to
ccbaf3f
Compare
Thanks for the help, @bartsmykla! I was a bit busy in the last few days, couldn't find a chance to address the comments. I am ok to go ahead 👍 (I think we tried to fix the failing tests at the same time, thus I reverted my latest commit.) |
Added validation for targetRef name and tags as required. Also, MeshGateway and MeshHTTPRoute kind validations are included.
Fix #7912
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?