Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): allow to disable KDS SOTW grpc api #7961

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Oct 4, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lukidzi lukidzi requested a review from a team as a code owner October 4, 2023 10:20
@lukidzi lukidzi requested review from Automaat and bartsmykla and removed request for a team October 4, 2023 10:20
pkg/config/loader_test.go Outdated Show resolved Hide resolved
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi merged commit d756e47 into kumahq:master Oct 4, 2023
@lahabana lahabana changed the title feat(kuma-cp): allow to disable KDS SOTW grpc api feat(kds): allow to disable KDS SOTW grpc api Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants