Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): make CNI configmap and serviceaccount support custom namespace #7956

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix(helm): make CNI configmap and serviceaccount support custom namespace #7956

merged 2 commits into from
Oct 4, 2023

Conversation

slavogiez
Copy link
Contributor

@slavogiez slavogiez commented Oct 4, 2023 •
edited
Loading

Fixes #7957

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slavogiez slavogiez force-pushed the fix/cni-custom-namespace branch 8 times, most recently from d9fce7c to 8552cc7 Compare October 4, 2023 07:12
@slavogiez slavogiez changed the title fix(cni): make configmap and serviceAccount support custom namespace fix(helm): make configmap and serviceaccount support custom namespace Oct 4, 2023
@slavogiez slavogiez changed the title fix(helm): make configmap and serviceaccount support custom namespace fix(helm): make CNI configmap and serviceaccount support custom namespace Oct 4, 2023
@jakubdyszkiewicz
Copy link
Contributor

/golden_files

@slavogiez slavogiez force-pushed the fix/cni-custom-namespace branch 2 times, most recently from 07811f7 to 4763f0f Compare October 4, 2023 09:00
slavogiez and others added 2 commits October 4, 2023 14:48
@slavogiez
fix(helm): make CNI configmap and serviceaccount support custom names…
093cdd5 
…pace

Signed-off-by: slavogiez <[email protected]>
@github-actions @slavogiez
fix(ci): format files
27b7112 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: slavogiez <[email protected]>
@slavogiez slavogiez force-pushed the fix/cni-custom-namespace branch from 4763f0f to 27b7112 Compare October 4, 2023 12:48
@slavogiez slavogiez marked this pull request as ready for review October 4, 2023 15:00
@slavogiez slavogiez requested a review from a team as a code owner October 4, 2023 15:00
@slavogiez slavogiez requested review from slonka and jakubdyszkiewicz and removed request for a team October 4, 2023 15:00
@jakubdyszkiewicz jakubdyszkiewicz merged commit d4e70cc into kumahq:master Oct 4, 2023
@jakubdyszkiewicz
Copy link
Contributor

thank you for the contribution!

@slonka
Copy link
Contributor

slonka commented Oct 4, 2023

Wasn't this on purpose? If you put it in another namespace isn't there a scheduling / priority issue? @jakubdyszkiewicz

@slavogiez slavogiez deleted the fix/cni-custom-namespace branch October 5, 2023 09:57
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use CNI custom namespace when deploying with Helm chart
3 participants
@slavogiez @jakubdyszkiewicz @slonka