Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): don't add postStart hook to builtin gateway even if waitForDataplaneReady: true #7939

Merged

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Oct 2, 2023

Changes:

  • always pass waitForDataplaneReady: false when generating builtin gateway pod
  • bind envoy admin to ::1 and set waitForDataplaneReady: true in e2e-multizone

Note: even though postStart hook should be completely harmless for builtin gateway for some reason it doesn't work. Builtin gateway pod spends 3m in ContainerCreating phase, restarts, and then works as expected. @lukidzi do you know why this can happen?

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lobkovilya lobkovilya added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Oct 2, 2023
@lobkovilya lobkovilya changed the title test(e2e): bind Envoy Admin to '::1' when IPv6 is supported by the clusters fix(kuma-cp): don't add postStart hook to builtin gateway even if waitForDataplaneReady: true Oct 3, 2023
@lobkovilya lobkovilya marked this pull request as ready for review October 3, 2023 11:46
@lobkovilya lobkovilya requested a review from a team as a code owner October 3, 2023 11:46
@lobkovilya lobkovilya requested review from michaelbeaumont and lukidzi and removed request for a team October 3, 2023 11:46
@lobkovilya lobkovilya merged commit 2697f09 into kumahq:master Oct 3, 2023
@lobkovilya lobkovilya deleted the e2e/bind-envoy-admin-to-ip6-loopback branch October 3, 2023 14:06
@michaelbeaumont
Copy link
Contributor

@lobkovilya should we backport this to 2.4?

@lobkovilya
Copy link
Contributor Author

I don't think we should, you can work around this by adding a kuma.io/wait-for-dataplane-ready: false annotation to the builtin gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants