fix(kuma-cp): don't add postStart
hook to builtin gateway even if waitForDataplaneReady: true
#7939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
waitForDataplaneReady: false
when generating builtin gateway pod::1
and setwaitForDataplaneReady: true
in e2e-multizoneNote: even though
postStart
hook should be completely harmless for builtin gateway for some reason it doesn't work. Builtin gateway pod spends 3m inContainerCreating
phase, restarts, and then works as expected. @lukidzi do you know why this can happen?Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?