Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): make OpenTelemetry control plane tracing fully configurable #7936

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Oct 2, 2023

Closes #7161

The upstream library checks for OTLP_EXPORTER_OTEL_* variables.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner October 2, 2023 09:41
@michaelbeaumont michaelbeaumont requested review from slonka and jakubdyszkiewicz and removed request for a team October 2, 2023 09:41
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont changed the title feat(kuma-cp): make OpenTelemtry control plane tracing fully configurable feat(kuma-cp): make OpenTelemetry control plane tracing fully configurable Oct 2, 2023
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbeaumont michaelbeaumont merged commit 3fd5819 into kumahq:master Oct 3, 2023
@michaelbeaumont michaelbeaumont deleted the feat/otel-support branch October 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuring OpenTelemetry gRPC connection
2 participants