Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kds): don't inc KdsGenerationErrors when context canceled #7913

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 28, 2023

Note: as a consequence, the canceled reconcile run is no longer "represented" in the metrics. It's not fully clear to me whether this would lead to inconsistencies. Nvm of course this goes into the other metric as no changes.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 28, 2023 15:29
@michaelbeaumont michaelbeaumont requested review from jakubdyszkiewicz and lobkovilya and removed request for a team September 28, 2023 15:29
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) September 28, 2023 15:43
@michaelbeaumont michaelbeaumont merged commit 557f437 into kumahq:master Sep 28, 2023
@michaelbeaumont michaelbeaumont deleted the fix/kds-gen-error-no-cancel branch September 28, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants