Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): fix global insight endpoint zone cp count #7872

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Sep 26, 2023

Fixes: #7851

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(api-server): implement new Global Insight endpoint

@Automaat Automaat requested a review from a team as a code owner September 26, 2023 11:24
@Automaat Automaat requested review from jakubdyszkiewicz and lukidzi and removed request for a team September 26, 2023 11:24
@Automaat Automaat merged commit cf6572a into kumahq:master Sep 26, 2023
@Automaat Automaat deleted the fix/global_insight_zone_cp_count branch September 26, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counter of Zones in Global Insight is not correct
2 participants