Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kds): call CloseSend and exit a goroutine when sync fails to start #7869

Merged
merged 4 commits into from
Sep 26, 2023
Merged

fix(kds): call CloseSend and exit a goroutine when sync fails to start #7869

merged 4 commits into from
Sep 26, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Sep 26, 2023

Checklist prior to review

While running locally I've noticed that when Zone cannot connect to the Global we were incorrectly handling errors. Stop channel reacts only on signal and it was hanging on this line until zone was terminated. That cause that method CloseSend wasn't called and coroutine was hanging causing leak of goroutines. It shouldn't leak the connection though.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lukidzi
fix(kuma-cp): close sending stream on error
d812ebc 
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi
fix(kuma-cp): change channel
52d0f37 
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi
fix(kuma-cp): change comment
4ff1e0e 
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi marked this pull request as ready for review September 26, 2023 11:43
@lukidzi lukidzi requested a review from a team as a code owner September 26, 2023 11:43
@lukidzi lukidzi requested review from jakubdyszkiewicz and lobkovilya and removed request for a team September 26, 2023 11:43
@lukidzi lukidzi merged commit 6e83b4a into kumahq:master Sep 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

backporting to release-2.3 with action

backporting to release-2.0 with action
backporting to release-2.1 with action
backporting to release-2.4 with action
backporting to release-2.2 with action

@kumahq kumahq bot mentioned this pull request Sep 26, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
@lukidzi @jakubdyszkiewicz @kumahq
fix(kds): call CloseSend and exit a goroutine when sync fails to start (
502e9fe 
#7869)

Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Jakub Dyszkiewicz <[email protected]>
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
@lukidzi @jakubdyszkiewicz @kumahq
fix(kds): call CloseSend and exit a goroutine when sync fails to start (
bb2af35 
#7869)

Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Jakub Dyszkiewicz <[email protected]>
@kumahq kumahq bot mentioned this pull request Sep 26, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
@lukidzi @jakubdyszkiewicz @kumahq
fix(kds): call CloseSend and exit a goroutine when sync fails to start (
4e5c110 
#7869)

Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Jakub Dyszkiewicz <[email protected]>
This was referenced Sep 26, 2023
Closed
Merged
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
@lukidzi @jakubdyszkiewicz @kumahq
fix(kds): call CloseSend and exit a goroutine when sync fails to start (
5041102 
#7869)

Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Jakub Dyszkiewicz <[email protected]>
@kumahq kumahq bot mentioned this pull request Sep 26, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
@lukidzi @jakubdyszkiewicz @kumahq
fix(kds): call CloseSend and exit a goroutine when sync fails to start (
39cbba8 
#7869)

Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Jakub Dyszkiewicz <[email protected]>
lukidzi added a commit that referenced this pull request Sep 26, 2023
@kumahq @lukidzi @jakubdyszkiewicz
fix(kds): call CloseSend and exit a goroutine when sync fails to star…
c37c982 
…t (backport of #7869) (#7883)

fix(kds): call CloseSend and exit a goroutine when sync fails to start (#7869)

Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Jakub Dyszkiewicz <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukidzi @jakubdyszkiewicz