Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add service-account features to egress and ingress #7864

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat(helm): add service-account features to egress and ingress #7864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.dump-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,12 @@ ingress:

# -- Security context at the container level for ingress
containerSecurityContext:
readOnlyRootFilesystem: true
readOnlyRootFilesystem: true

# -- Annotations to add for Control Plane's Service Account
serviceAccountAnnotations: { }
# -- Whether to automountServiceAccountToken for cp. Optionally set to false
automountServiceAccountToken: true

egress:
# -- If true, it deploys Egress for cross cluster communication
Expand Down Expand Up @@ -602,7 +607,12 @@ egress:

# -- Security context at the container level for egress
containerSecurityContext:
readOnlyRootFilesystem: true
readOnlyRootFilesystem: true

# -- Annotations to add for Control Plane's Service Account
serviceAccountAnnotations: { }
# -- Whether to automountServiceAccountToken for cp. Optionally set to false
automountServiceAccountToken: true

kumactl:
image:
Expand Down
1 change: 1 addition & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-egress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down
2 changes: 2 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6659,6 +6659,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-egress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down Expand Up @@ -6789,6 +6790,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-ingress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-ingress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down
1 change: 1 addition & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix4496.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-ingress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down
2 changes: 2 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix4935.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-egress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down Expand Up @@ -972,6 +973,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-ingress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down
2 changes: 2 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix5978.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-egress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down Expand Up @@ -741,6 +742,7 @@ spec:
runAsNonRoot: true
runAsUser: 5678
serviceAccountName: kuma-ingress
automountServiceAccountToken: true
nodeSelector:

kubernetes.io/os: linux
Expand Down
Loading