fix(api-server): improve HandleError to handle rest_errors.Error and fix Unauthenticated error handling #7818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Unauthenticated error handling * Update HandleError to process pointer to rest_errors.Error as an argument. This allows us to use errors.As directly, which simplifies the code and slightly improves performance. * Fix a bug in HandleError where it was incorrectly assigning err to itself in the case of an Unauthenticated error. Signed-off-by: Bart Smykla <[email protected]>
slonka
approved these changes
Sep 22, 2023
michaelbeaumont
approved these changes
Sep 22, 2023
| Status: 403, | ||
| Title: "Access Denied", | ||
| Detail: accessErr.Reason, | ||
| } | ||
| case errors.Is(err, &Unauthenticated{}): | ||
| var unauthenticated *Unauthenticated | ||
| errors.As(err, &err) | ||
| kumaErr = types.Error{ | ||
| errors.As(err, &unauthenticated) |
There was a problem hiding this comment.
Maybe just use _ if we know this will return true instead of ignoring
lahabana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update HandleError to process pointer to rest_errors.Error as an argument. This allows us to use errors.As directly, which simplifies the code and allows project depending on Kuma to handle not hardcoded errors.
Fix a bug in HandleError where it was incorrectly assigning err to itself in the case of an Unauthenticated error.
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OSUPGRADE.md?> Changelog:entry here or add aci/label to run fewer/more tests?