Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add owner to secrets #7736

Closed
wants to merge 1 commit into from
Closed

feat(store): add owner to secrets #7736

wants to merge 1 commit into from

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 12, 2023

closes #3276

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka slonka requested a review from bartsmykla September 12, 2023 09:45
@slonka slonka force-pushed the add-owners-to-the-secretmanager-new branch from 0490c0e to f215a81 Compare September 12, 2023 09:46
@slonka slonka force-pushed the add-owners-to-the-secretmanager-new branch from f215a81 to d694f8a Compare September 12, 2023 09:53
lahabana
lahabana reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the be something also for non k8s?

@slonka
Copy link
Contributor Author

slonka commented Sep 12, 2023

Closing due to not being needed, will add more detail in tomorrows meeting.

@slonka slonka closed this Sep 12, 2023
@slonka slonka mentioned this pull request Sep 15, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Owners to the SecretManager
2 participants
@slonka @lahabana