Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): add metrics to event based watchdog #7651

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

This PR adds more granular metrics to kds reconciller and unit tests to the experimental watchdog.

We want to measure what triggered watchdog flush (event or resync) and what is the result (was something changed or did we waste CPU time). This way we can discover how useful is resync and whether we can change the resync of 60s to something like 5mins or 1h etc and save CPU resources.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner September 5, 2023 10:49
@jakubdyszkiewicz jakubdyszkiewicz requested review from slonka and bartsmykla and removed request for a team September 5, 2023 10:49
@jakubdyszkiewicz jakubdyszkiewicz merged commit 456cd23 into kumahq:master Sep 5, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the event-watchdog-metrics branch September 5, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants