-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transparent-proxy): add --exclude-outbound-ports-for-uids
#7588
Conversation
app/kumactl/cmd/install/testdata/install-transparent-proxy.dns.golden.txt
Outdated
Show resolved
Hide resolved
app/kumactl/cmd/install/testdata/install-transparent-proxy.dns.golden.txt
Outdated
Show resolved
Hide resolved
/golden_files |
|
@slonka not anymore :) I've taken the time to fix it. Tests like this that don't rely on golden files are frustrating :) |
there is a warning generated somewhere |
Yes finally found it. (We were using stdout instead of stderr...) |
app/kumactl/cmd/install/testdata/install-transparent-proxy.dns.golden.txt
Outdated
Show resolved
Hide resolved
ada86c1
to
242409b
Compare
@slonka and @bartsmykla I've finally got around to updating this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked at the force pushed diff, looks good 👍
…for-uids` More possibility for wildcarding to make it easy to exclude everything for a uid Fix multiport and invalid list of uids Signed-off-by: Charly Molter <[email protected]>
More possibility for wildcarding to make it easy to exclude everything for a uid
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?