Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transparent-proxy): add --exclude-outbound-ports-for-uids #7588

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

lahabana
Copy link
Contributor

More possibility for wildcarding to make it easy to exclude everything for a uid

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested a review from a team as a code owner August 24, 2023 10:48
@lahabana lahabana requested review from jakubdyszkiewicz and lukidzi and removed request for a team August 24, 2023 10:48
@lahabana lahabana requested review from slonka and bartsmykla and removed request for jakubdyszkiewicz and lukidzi August 24, 2023 12:52
app/kumactl/cmd/install/install_transparent_proxy.go Outdated Show resolved Hide resolved
app/kumactl/cmd/install/install_transparent_proxy.go Outdated Show resolved Hide resolved
pkg/transparentproxy/transparentproxy_v2.go Outdated Show resolved Hide resolved
pkg/transparentproxy/transparentproxy_v2.go Outdated Show resolved Hide resolved
pkg/transparentproxy/transparentproxy_v2.go Outdated Show resolved Hide resolved
pkg/transparentproxy/transparentproxy_v2.go Outdated Show resolved Hide resolved
pkg/transparentproxy/transparentproxy_v2.go Outdated Show resolved Hide resolved
@bartsmykla
Copy link
Contributor

/golden_files

@slonka
Copy link
Contributor

slonka commented Aug 25, 2023

/golden_files does not work, you need to manually run this, FYI @bartsmykla @lahabana

@lahabana
Copy link
Contributor Author

@slonka not anymore :) I've taken the time to fix it. Tests like this that don't rely on golden files are frustrating :)

@slonka
Copy link
Contributor

slonka commented Aug 25, 2023

Expected
    <string>: "# [WAR..."
to equal       |
    <string>: "* nat
    ..."

there is a warning generated somewhere

@lahabana
Copy link
Contributor Author

there is a warning generated somewhere

Yes finally found it. (We were using stdout instead of stderr...)

@lahabana
Copy link
Contributor Author

lahabana commented Oct 3, 2023

@slonka and @bartsmykla I've finally got around to updating this

@lahabana lahabana removed the ci/skip-e2e-test PR: Don't run e2e tests label Oct 4, 2023
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the force pushed diff, looks good 👍

…for-uids`

More possibility for wildcarding to make it easy to exclude everything
for a uid
Fix multiport and invalid list of uids

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana enabled auto-merge (squash) October 5, 2023 11:17
@lahabana lahabana merged commit 124887f into kumahq:master Oct 5, 2023
@lahabana lahabana deleted the simplifyUID branch March 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants