Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(policy): added better message when no proxyTypes #12754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Feb 4, 2025

Motivation

The validation message wasn't helpful and a user had an issue to understand what was wrong.

Implementation information

Improved a message to give more details

Supporting documentation

Fix #10907

@lukidzi lukidzi requested a review from a team as a code owner February 4, 2025 18:04
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@lukidzi lukidzi changed the title fix(policies): added better message when no proxyTypes fix(policy): added better message when no proxyTypes Feb 4, 2025
@@ -207,7 +207,7 @@ from:
[]validators.Violation{
{
Field: "spec.from",
Message: "must not be defined",
Message: "must not be defined when the scope includes a Gateway, exclude non-gateway resources or select only gateways and use spec.to",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"exclude non-gateway" has the same meaning as "select only gateways" :) probably should be

must not be defined when the scope includes a Gateway, select only proxyType Sidecar or select only gateways and use spec.to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshFaultInjection validation error message should be more specific
2 participants