Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watchdog): wait for the first tick #12693

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jan 28, 2025

Motivation

Issue: #12657

Implementation information

Changed to wait for the HasTicked to be called before first Ticker event, since there was a race and sometimes on ticked happened before the assertion

fix: #12657

@lukidzi lukidzi requested a review from lahabana January 28, 2025 14:04
@lukidzi lukidzi requested a review from a team as a code owner January 28, 2025 14:04
@lukidzi lukidzi requested a review from lobkovilya January 28, 2025 14:04
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested a review from lobkovilya January 30, 2025 18:00
@lukidzi lukidzi added the ci/skip-e2e-test PR: Don't run e2e tests label Jan 31, 2025
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested a review from lobkovilya January 31, 2025 15:49
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested a review from lobkovilya February 3, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake SimpleWatchdog [It] should wait for the first tick to happen on WaitForFirstTick
2 participants