Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make automounting of service accounts configurable for zone ingress and egress #7824

Closed
calvin-sk-lee opened this issue Sep 25, 2023 · 0 comments · Fixed by #7864
Closed

Make automounting of service accounts configurable for zone ingress and egress #7824

calvin-sk-lee opened this issue Sep 25, 2023 · 0 comments · Fixed by #7864
Assignees
@lahabana
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@calvin-sk-lee
Copy link

Description

Configuration of automounting of service accounts for zone ingress and egress are missing.
@calvin-sk-lee calvin-sk-lee added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Sep 25, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 25, 2023
lahabana added a commit to lahabana/kuma that referenced this issue Sep 25, 2023
@lahabana
feat(helm): add service-account features to egress and ingress
8eb6320 
Add features that existed for the CP but not ingress/egress:

- imagePullSecrets (for egress)
- serviceAccountAnnotations
- automountServiceAccountToken

Fix kumahq#7824

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana mentioned this issue Sep 25, 2023
Merged
6 tasks
@lahabana lahabana self-assigned this Sep 25, 2023
lahabana added a commit to lahabana/kuma that referenced this issue Sep 26, 2023
@lahabana
feat(helm): add service-account features to egress and ingress
a941541 
Add features that existed for the CP but not ingress/egress:

- imagePullSecrets (for egress)
- serviceAccountAnnotations
- automountServiceAccountToken

Fix kumahq#7824

Signed-off-by: Charly Molter <[email protected]>
lahabana added a commit that referenced this issue Sep 27, 2023
@lahabana
feat(helm): add service-account features to egress and ingress (#7864)
107d388 
Add features that existed for the CP but not ingress/egress:

- imagePullSecrets (for egress)
- serviceAccountAnnotations
- automountServiceAccountToken

Fix #7824

Signed-off-by: Charly Molter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahabana lahabana

Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(helm): add service-account features to egress and ingress lahabana/kuma
3 participants
@lahabana @jakubdyszkiewicz @calvin-sk-lee