Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI with GitHub Actions #8

Merged
merged 1 commit into from
Jul 6, 2021
Merged

CI with GitHub Actions #8

merged 1 commit into from
Jul 6, 2021

Conversation

dpo
Copy link
Contributor

@dpo dpo commented Jun 21, 2021

This will allow you to do CI on Linux, macOS and Windows once #7 has been sorted out. You can also test FreeBSD with Cirrus.jl if you like.

strategy:
fail-fast: false
matrix:
version: ['1.3', '1']
Copy link
Member

@lostella lostella Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to test on more recent versions as well? At least 1.6 should be there I guess

Suggested change
version: ['1.3', '1']
version: ['1.6', '1.3', '1']

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“1” actually always represents the latest stable. Currently, that would be 1.6.1.

@Benny44 Benny44 merged commit 42c0388 into kul-optec:master Jul 6, 2021
@dpo
Copy link
Contributor Author

dpo commented Jul 6, 2021

Thanks!

@dpo dpo deleted the actions branch July 6, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants