feat: Button, AnchorButton コンポーネントを追加 (SHRUI-545)
#2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
wmoai
requested review from
uknmr and
zoshigayan
and removed request for
a team
✅ Deploy Preview for smarthr-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
uknmr
requested changes
Apr 25, 2022
| ${styles.disabled} | ||
|
|
||
| /* alpha color を使用しているので、背景色と干渉させない */ | ||
| background-clip: padding-box; |
There was a problem hiding this comment.
nits
Suggested change
| background-clip: padding-box; | |
| background-clip: padding-box; |
| ${styles.disabled} | ||
|
|
||
| /* alpha color を使用しているので、背景色と干渉させない */ | ||
| background-clip: padding-box; |
There was a problem hiding this comment.
nits
Suggested change
| background-clip: padding-box; | |
| background-clip: padding-box; |
| ${baseStyles} | ||
| ${styles.default} | ||
|
|
||
| &:focus, |
There was a problem hiding this comment.
:focus-visible でお願いします。
Suggested change
| &:focus, | |
| &:focus-visible, |
| ${styles.default} | ||
| text-decoration: none; | ||
|
|
||
| &:focus, |
There was a problem hiding this comment.
:focus-visible でお願いします。
Suggested change
| &:focus, | |
| &:focus-visible, |
| min-height: calc(${fontSize.S} + ${spacingByChar(1)} + (${border.lineWidth} * 2)); | ||
| } | ||
|
|
||
| &:focus { |
There was a problem hiding this comment.
:focus-visible でお願いします。
Suggested change
| &:focus { | |
| &:focus-visible { |
|
すみません、エスケープハッチ付け忘れてたので追加しました！ e45bb55 |
uknmr
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
https://smarthr.atlassian.net/browse/SHRUI-545
Overview
既存のボタンコンポーネントは
PrimaryButton,SecondaryButtonなど種類毎に別コンポーネントになっていますが、コンポーネントをButtonとAnchorButtonに統一し、variantProps で種類を選べるように変更します。What I did
Button,AnchorButtonを追加variant?: 'primary' | 'secondary' | 'danger' | 'skeleton' | 'text'、デフォルトはsecondaryPrimaryButtonPrimaryButtonAnchorSecondaryButtonSecondaryButtonAnchorDangerButtonDangerButtonAnchorSkeletonButtonSkeletonButtonAnchorTextButtonTextButtonAnchorcolor.disableColor(color.TEXT_DISABLED)で二重に色が薄くなっていたので、単にTEXT_DISABLEDになるように修正Capture