Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update palette of theme #220

Merged
merged 24 commits into from
Aug 5, 2019
Merged

Update palette of theme #220

merged 24 commits into from
Aug 5, 2019

Conversation

im36-123
Copy link
Contributor

@im36-123 im36-123 commented Aug 1, 2019

This PR include BREAKING CHANGE.

I updated color of theme. Because the current theme file is different from the sketch file (that is defined in the SmartHR, Inc.)
And I added hoverColor method to get the color when hovered.

@im36-123 im36-123 requested a review from nabeliwo August 1, 2019 02:52
@auto-assign auto-assign bot requested a review from wacky August 1, 2019 02:52
@reg-suit
Copy link

reg-suit bot commented Aug 1, 2019

reg-suit detected visual differences.

Check this report, and review them.

⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@netlify
Copy link

netlify bot commented Aug 1, 2019

Deploy preview for smarthr-ui ready!

Built with commit 5e91962

https://deploy-preview-220--smarthr-ui.netlify.com

@im36-123 im36-123 requested review from ouji-miyahara and removed request for wacky August 1, 2019 03:22
@nabeliwo
Copy link
Member

nabeliwo commented Aug 1, 2019

Please run yarn test:update-snapshot.

Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ouji-miyahara ouji-miyahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いグルーブでした。LGTM

@im36-123
Copy link
Contributor Author

im36-123 commented Aug 5, 2019

Thank you for your review !

@im36-123 im36-123 merged commit de50fd8 into master Aug 5, 2019
@nabeliwo nabeliwo deleted the TTMZ-14 branch February 28, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants