[xnet/xhttp] fix goroutine leak (#5)

kucherenkovova · Jun 13, 2024 · a9c2e24 · a9c2e24
1 parent 81a8cab
commit a9c2e24
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/xnet/xhttp/README.md b/xnet/xhttp/README.md
@@ -3,5 +3,5 @@ Extensions to the standard Go library's `net/http` package. `ListenAndServe` alt
 
 ### Install
 ```
-go get github.com/kucherenkovova/gopypaste/xnet/[email protected].1
+go get github.com/kucherenkovova/gopypaste/xnet/[email protected].2
 ```
diff --git a/xnet/xhttp/server.go b/xnet/xhttp/server.go
@@ -14,13 +14,19 @@ func ListenAndServeContext(ctx context.Context, addr string, handler http.Handle
 	defer cancel()
 
 	server := &http.Server{Addr: addr, Handler: handler}
+	done := make(chan struct{})
 
 	go func() {
-		<-ctx.Done()
-		_ = server.Shutdown(context.Background())
+		select {
+		case <-ctx.Done():
+			_ = server.Shutdown(context.Background())
+		case <-done:
+			return
+		}
 	}()
 
 	if err := server.ListenAndServe(); err != nil && !errors.Is(err, http.ErrServerClosed) {
+		close(done)
 		return err
 	}