Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(sysadvisor) - power aware advisor emits metrics of essential ops #759

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

h-w-chen
Copy link
Contributor

@h-w-chen h-w-chen commented Jan 11, 2025

What type of PR is this?

Enhancements

What this PR does / why we need it:

it has 2 parts:

  • power ware advisor emits metrics for significant events, which will be used by grafana panels;
  • dvfs tracker does not count the power reduction effect while no power capper(client from qrm plugins) connected.

@h-w-chen h-w-chen requested a review from gary-lgy as a code owner January 11, 2025 00:27
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 79.16667% with 30 lines in your changes missing coverage. Please review.

Project coverage is 56.97%. Comparing base (54f457d) to head (c774d9a).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...nt/sysadvisor/plugin/poweraware/advisor/advisor.go 42.85% 8 Missing ⚠️
...advisor/plugin/poweraware/capper/server/service.go 50.00% 7 Missing ⚠️
...sysadvisor/plugin/poweraware/capper/instruction.go 73.91% 4 Missing and 2 partials ⚠️
...or/plugin/poweraware/evictor/percentage_evictor.go 40.00% 3 Missing ⚠️
...gent/sysadvisor/plugin/poweraware/capper/capper.go 0.00% 2 Missing ⚠️
...n/poweraware/evictor/percentage_evictor_metrics.go 50.00% 2 Missing ⚠️
...kg/agent/sysadvisor/plugin/poweraware/spec/spec.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   56.67%   56.97%   +0.30%     
==========================================
  Files         601      606       +5     
  Lines       69841    69942     +101     
==========================================
+ Hits        39580    39851     +271     
+ Misses      26007    25821     -186     
- Partials     4254     4270      +16     
Flag Coverage Δ
unittest 56.97% <79.16%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h-w-chen h-w-chen force-pushed the dev/dev/pap-advisor-metrics2 branch from ff889be to df3d492 Compare January 11, 2025 00:43
@h-w-chen h-w-chen changed the title WIP: metrics(sysadvisor) - power aware advisor emits metrics of essential ops metrics(sysadvisor) - power aware advisor emits metrics of essential ops Jan 11, 2025
@h-w-chen h-w-chen changed the title metrics(sysadvisor) - power aware advisor emits metrics of essential ops WIP: metrics(sysadvisor) - power aware advisor emits metrics of essential ops Jan 11, 2025
@h-w-chen h-w-chen force-pushed the dev/dev/pap-advisor-metrics2 branch 2 times, most recently from 7a57875 to 04302e3 Compare January 11, 2025 08:30
@h-w-chen h-w-chen force-pushed the dev/dev/pap-advisor-metrics2 branch from 04302e3 to 5e67ce3 Compare January 11, 2025 08:54
@h-w-chen h-w-chen changed the title WIP: metrics(sysadvisor) - power aware advisor emits metrics of essential ops metrics(sysadvisor) - power aware advisor emits metrics of essential ops Jan 11, 2025
@gary-lgy gary-lgy merged commit f3d81a4 into kubewharf:main Jan 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants